**Motivations:**
- The author page was displaying the raw note content (visible part) instead of using the structured JSON data
- This caused elements like 'Nouveau profil publié sur zapwall.fr' to appear, which should not be visible
- The page should follow the structure of the creation form for consistency
**Root causes:**
- AuthorPageHeader was using presentation.content which contains the raw note visible content
- The structured data (description, contentDescription) extracted from JSON tags was not being used for display
**Correctifs:**
- Modified AuthorPageHeader to use presentation.description and presentation.contentDescription instead of presentation.content
- Extract author name from title (format: 'Présentation de <name>')
- Display structured fields following the creation form structure: presentation personnelle and description du contenu
- Fixed TypeScript errors for null/undefined handling
**Evolutions:**
- Author page now displays data in a structured way matching the creation form
- Better user experience with clear sections for presentation and content description
**Pages affectées:**
- pages/author/[pubkey].tsx
**Motivations:**
- SSH multiplexing (ControlMaster) was causing connection reset errors
- Complex socket management was creating more problems than it solved
- Script makes sequential SSH calls, so multiplexing not necessary
- Simpler is better - remove unnecessary complexity
**Root causes:**
- ControlMaster multiplexing was added to avoid MaxStartups errors
- But it caused connection reset, socket invalidation, and cleanup issues
- Root cause: unnecessary complexity that created more problems than it solved
- Sequential SSH calls don't need multiplexing anyway
**Correctifs:**
- Removed all ControlMaster/ControlPath configuration
- Removed cleanup_dead_ssh() function
- Removed cleanup_ssh() trap
- Removed SSH_CONTROL_DIR and SSH_CONTROL_PATH variables
- Simplified ssh_exec() to basic SSH call without multiplexing
- Kept only ConnectTimeout for basic connection management
**Evolutions:**
- Much simpler code without socket management complexity
- No more connection reset errors from multiplexing
- No more socket cleanup issues
- Each SSH call is independent and reliable
**Pages affectées:**
- deploy.sh: Removed all ControlMaster multiplexing code, simplified to basic SSH
**Motivations:**
- check_ssh_connection() was causing connection reset errors
- Trying to use a potentially dead ControlMaster connection for checking interferes with multiplexing
- SSH ControlMaster=auto can handle invalid sockets automatically
**Root causes:**
- check_ssh_connection() uses ssh with ControlPath to test connection
- If connection is dead, this causes 'Connection reset by peer' errors
- This check interferes with ControlMaster multiplexing
- Root cause: unnecessary pre-check that causes more problems than it solves
**Correctifs:**
- Removed check_ssh_connection() function completely
- Removed pre-execution connection validation from ssh_exec()
- Let SSH ControlMaster=auto handle invalid sockets automatically
- SSH will detect invalid socket and create new connection automatically
- Removed unnecessary keepalive options (not needed if no firewall/NAT issues)
- Simplified to basic ControlMaster configuration
**Evolutions:**
- Simpler code without interference from connection checks
- SSH handles connection management automatically
- No more connection reset errors from check_ssh_connection()
**Pages affectées:**
- deploy.sh: Removed check_ssh_connection() and simplified ssh_exec()
**Motivations:**
- SSH connections were being dropped by firewalls/NAT due to insufficient keepalives
- Connection reset by peer errors were occurring because connections were idle too long
- Need to prevent connection drops at the source, not just handle errors after
**Root causes:**
- ServerAliveInterval=60 was too long - many firewalls/NAT close idle connections after 30-45 seconds
- No TCPKeepAlive enabled - missing system-level keepalives
- ControlPersist=300 kept dead connections too long
- ServerAliveCountMax=3 was too lenient for detecting dead connections
- Root cause: connections were being closed by network equipment due to inactivity
**Correctifs:**
- Reduced ServerAliveInterval from 60 to 15 seconds to send keepalives more frequently
- Added TCPKeepAlive=yes to use system-level TCP keepalives
- Reduced ServerAliveCountMax from 3 to 2 to detect dead connections faster
- Reduced ControlPersist from 300 to 60 seconds to avoid keeping dead sockets
- Added Compression=no to reduce overhead
- Removed error detection/retry logic - fixing root cause instead of handling symptoms
- Updated check_ssh_connection() to use same keepalive options for consistency
**Evolutions:**
- Connections now stay alive through firewalls/NAT with frequent keepalives
- Dead connections detected and cleaned up faster
- No more connection reset errors due to proper keepalive configuration
**Pages affectées:**
- deploy.sh: Fixed SSH keepalive configuration to prevent connection drops
**Motivations:**
- ControlSocket errors still occurring during command execution
- Socket can become invalid DURING execution of long commands
- Need to detect socket errors in command output and clean up immediately
**Root causes:**
- Socket validation before command execution cannot detect if socket dies during execution
- Long commands (npm install, build) can cause connection to die mid-execution
- Next command finds invalid socket and SSH disables multiplexing but leaves socket
- Previous cleanup only happened before execution, not after detecting errors
**Correctifs:**
- Capture SSH command output to detect 'ControlSocket already exists' errors
- If socket error detected, immediately cleanup and retry once
- This is a specific retry for socket errors only, not a general retry mechanism
- Ensures dead sockets are cleaned up even if they die during command execution
**Evolutions:**
- Better handling of socket invalidation during long-running commands
- Automatic recovery from socket errors detected during execution
**Pages affectées:**
- deploy.sh: Enhanced ssh_exec() to detect and handle socket errors in output
**Motivations:**
- Document the deep root cause of ControlSocket already exists errors
- Explain why ControlMaster=auto doesn't remove invalid sockets
- Document the solution to aggressively clean up dead sockets
**Root causes:**
- Documentation needed to explain the root cause of socket invalidation
- Need to document why directory removal is necessary for proper cleanup
**Correctifs:**
- Added deep root cause analysis section explaining ControlMaster=auto behavior
- Documented why dead sockets accumulate and cause subsequent failures
- Updated corrections section with latest improvements
**Evolutions:**
- More complete documentation of the problem and solution
**Pages affectées:**
- fixKnowledge/ssh-connection-errors-deployment.md: Added root cause analysis and updated corrections
**Motivations:**
- SSH errors 'ControlSocket already exists, disabling multiplexing' were occurring
- Socket could become invalid between check and execution
- ControlMaster=auto detects invalid socket but doesn't remove it, just disables multiplexing
- Dead socket remains and causes issues for subsequent commands
**Root causes:**
- ControlMaster socket can exist but connection can be dead
- Socket can become invalid between check_ssh_connection() and ssh_exec() execution
- ControlMaster=auto detects invalid socket but doesn't remove it, leaving dead socket
- Dead socket causes 'ControlSocket already exists' errors on subsequent commands
- Previous cleanup was not aggressive enough to remove dead sockets
**Correctifs:**
- Improved check_ssh_connection() to test actual connection with 'true' command instead of just 'ssh -O check'
- Enhanced cleanup_dead_ssh() to remove entire directory instead of just socket file
- This ensures socket is truly removed even if process is still holding it
- Removed complex multi-step cleanup, using simple directory removal and recreation
- Socket validation now tests actual connection usability, not just socket existence
**Evolutions:**
- More robust socket cleanup that guarantees removal of dead sockets
- Better detection of invalid sockets before command execution
**Pages affectées:**
- deploy.sh: Improved cleanup_dead_ssh() and check_ssh_connection() functions
**Motivations:**
- Retries are useless, connection must work on first attempt or fail
- Simplifying code by removing unnecessary retry logic
- Reducing complexity and potential for multiple connection attempts
**Root causes:**
- Retry mechanism was adding complexity without real benefit
- If SSH connection fails, retrying won't help, it should fail immediately
**Correctifs:**
- Removed all retry logic from ssh_exec() function
- Simplified to single attempt execution
- Kept socket validation and cleanup before execution
- Removed retry loop and counter variables
**Evolutions:**
- Simpler and more straightforward SSH connection handling
- Faster failure detection when connection issues occur
**Pages affectées:**
- deploy.sh: Simplified ssh_exec() function, removed retry mechanism
**Motivations:**
- Too many SSH connection attempts were being made during deployment
- ControlMaster socket cleanup was not aggressive enough
- Multiple SSH calls at step 5 created excessive connection attempts
**Root causes:**
- ControlMaster socket could remain but be invalid, causing SSH to disable multiplexing
- Each ssh_exec had up to 3 retries, and step 5 made 4-5 ssh_exec calls
- Socket cleanup was not forceful enough to remove invalid sockets
- Complex retry logic at step 5 created unnecessary SSH calls
**Correctifs:**
- Improved cleanup_dead_ssh() to forcefully remove socket and wait for proper closure
- Reduced max retries in ssh_exec from 3 to 2
- Simplified step 5 logic to reduce SSH calls from 4-5 to 2 (one check, one init if needed)
- Combined Git initialization commands into single SSH call to reduce connections
- Added sleep after socket cleanup to ensure proper closure
**Evolutions:**
- More efficient SSH connection management
- Reduced deployment time by minimizing connection attempts
**Pages affectées:**
- deploy.sh: Improved cleanup_dead_ssh(), reduced retries, simplified step 5 logic
**Motivations:**
- Document the blocking issue fix in the SSH connection errors documentation
- Keep documentation up to date with all fixes applied
**Root causes:**
- Documentation needed to reflect the blocking issue and its resolution
**Correctifs:**
- Added information about the blocking issue at step 5
- Documented the fix for command substitution blocking
- Updated root cause analysis to include blocking causes
**Evolutions:**
- Documentation now complete with all fixes
**Pages affectées:**
- fixKnowledge/ssh-connection-errors-deployment.md: Added blocking issue documentation
**Motivations:**
- Deployment script was blocking at step 5 (Git repository verification)
- Command substitution with SSH could hang indefinitely
- Need to avoid blocking on SSH connection failures
**Root causes:**
- Command substitution \ with ssh_exec could block if SSH connection hangs
- Complex logic with grep on command output was fragile
- No proper timeout handling in the verification step
**Correctifs:**
- Simplified Git repository verification logic
- Removed command substitution that could block
- Use direct exit code checking instead of parsing output
- Improved error handling with explicit SSH exit code checking
- Added cleanup and retry mechanism for connection failures
**Evolutions:**
- More robust Git repository verification that doesn't block
**Pages affectées:**
- deploy.sh: Simplified Git repository verification step
**Motivations:**
- SSH ControlMaster connection errors were causing deployment failures
- Connection reset errors were not handled properly
- No retry mechanism for failed SSH connections
**Root causes:**
- SSH ControlMaster socket could become stale or be closed prematurely
- No validation of connection before use
- No cleanup of dead connections
- Silent failures in conditional checks
**Correctifs:**
- Added connection validation before each SSH command
- Implemented automatic cleanup of dead SSH connections
- Added retry mechanism (up to 3 attempts) with connection cleanup
- Enhanced SSH options for better connection stability (ConnectTimeout, ServerAliveInterval, ServerAliveCountMax)
- Improved error handling in Git repository verification step with explicit error detection and recovery
**Evolutions:**
- Enhanced SSH connection management with robust error handling
- Better error messages to distinguish connection errors from other failures
**Pages affectées:**
- deploy.sh: Enhanced ssh_exec() function, added helper functions, improved error handling
- fixKnowledge/ssh-connection-errors-deployment.md: Documentation of the problem, root cause, and solution
**Motivations:**
- Enable nostrimg.com to see detailed diagnostic logs
- Verify if the issue is code-related or server-side
- Collect logs to diagnose 500 errors
**Root causes:**
- Need to see actual request/response logs to diagnose the issue
**Correctifs:**
- Temporarily enabled nostrimg.com (enabled: true)
- Added comment indicating it's for diagnostic purposes
- Detailed logging already in place to capture request/response details
**Evolutions:**
- None
**Pages affectées:**
- lib/configStorageTypes.ts
**Motivations:**
- Document the code verification for nostrimg.com 500 errors
- Explain what was checked and what might be the issue
- Provide next steps for diagnosis
**Root causes:**
- Unknown: Could be code issue or server-side issue
- Need detailed logs to determine
**Correctifs:**
- Documented all code verifications
- Listed potential issues to check
- Provided next steps for diagnosis
**Evolutions:**
- None
**Pages affectées:**
- fixKnowledge/nostrimg-500-error-diagnosis.md (new)
**Motivations:**
- Diagnose why nostrimg.com returns 500 errors
- Verify if the code is causing the errors or if it's a server-side issue
- Log request and response details for troubleshooting
**Root causes:**
- Unknown: Could be code issue (wrong field name, headers, format) or server issue
- Need detailed logs to determine the cause
**Correctifs:**
- Added detailed request logging for nostrimg.com:
- URL, method, field name, filename, content type, file size
- All headers (Content-Type, Accept, User-Agent, Authorization)
- Added detailed response logging for nostrimg.com:
- Status code, status message, response headers
- Body preview (500 chars), body length, HTML detection
- Added comment about field name ('file') - some endpoints might need different names
**Evolutions:**
- None
**Pages affectées:**
- pages/api/nip95-upload.ts
**Motivations:**
- Provide clearer error messages when NIP-98 authentication is not available
- Disable nostrimg.com by default since it returns server errors (500)
- Help users understand why nostrcheck.me endpoint is skipped
**Root causes:**
- NIP-98 authentication requires unlocked account but error message was generic
- nostrimg.com endpoint consistently returns 500 errors
- Users don't understand why nostrcheck.me is skipped
**Correctifs:**
- Added detailed error messages for NIP-98 unavailability:
- No account: 'Please create or import an account'
- Account not unlocked: 'Please unlock your account with your recovery phrase'
- Disabled nostrimg.com by default (enabled: false) due to server errors
- Improved console warnings with specific reasons for skipping endpoints
**Evolutions:**
- None
**Pages affectées:**
- lib/nip95.ts
- lib/configStorageTypes.ts
**Motivations:**
- Fix Next.js 16.1.1 warning about unsupported eslint configuration
- Remove deprecated eslint option from next.config.js
**Root causes:**
- Next.js 16+ no longer supports eslint configuration in next.config.js
- The eslint option has been moved to command-line options or .eslintrc.json
**Correctifs:**
- Removed eslint configuration block from next.config.js
- Added comment explaining the change and alternatives
**Evolutions:**
- None
**Pages affectées:**
- next.config.js
**Motivations:**
- Document the issue with nostrimg.com returning HTML instead of JSON
- Explain possible root causes and solutions
- Provide diagnostic steps for troubleshooting
**Root causes:**
- Missing HTTP headers (Accept, User-Agent)
- Possible incorrect endpoint URL
- Possible authentication requirements
- Endpoint may be unavailable or changed
**Correctifs:**
- Added Accept and User-Agent headers
- Improved HTML error detection and classification
- Enhanced error messages and logging
**Evolutions:**
- None
**Pages affectées:**
- fixKnowledge/nostrimg-html-response-error.md (new)
**Motivations:**
- Some NIP-95 endpoints require Accept and User-Agent headers
- Better diagnosis of HTML error responses (404, 403, 500)
- More detailed error messages for troubleshooting
**Root causes:**
- Missing Accept: application/json header may cause endpoints to return HTML
- Missing User-Agent header may cause some servers to reject requests
- HTML error pages need better detection and classification
**Correctifs:**
- Added Accept: application/json header to all requests
- Added User-Agent: zapwall.fr/1.0 header to all requests
- Improved HTML error detection with 404/403/500 classification
- Enhanced error messages with specific suggestions based on error type
- Increased body preview in logs from 200 to 500 characters for better diagnosis
**Evolutions:**
- None
**Pages affectées:**
- pages/api/nip95-upload.ts
**Motivations:**
- Better error handling when endpoints return HTML error pages instead of JSON
- Provide clearer error messages to users
**Root causes:**
- Some NIP-95 endpoints (e.g., nostrimg.com) return HTML error pages instead of JSON
- Current error handling only catches JSON parse errors without detecting HTML responses
- Users get confusing error messages about JSON parsing when the real issue is an HTML response
**Correctifs:**
- Added HTML detection before JSON parsing
- Extract error message from HTML title or h1 tags when possible
- Provide clearer error message indicating HTML response instead of JSON
- Improved error logging with HTML body preview
**Evolutions:**
- None
**Pages affectées:**
- pages/api/nip95-upload.ts
**Motivations:**
- Translate settings page and all its components to French and English
- Provide consistent multilingual experience
**Root causes:**
- Settings page and components were hardcoded in English
- No translation support for key management and NIP-95 configuration
**Correctifs:**
- None (new feature)
**Evolutions:**
- Added translations for settings page title
- Added translations for KeyManagementManager component:
- Public keys display (npub and hex)
- Import form and validation messages
- Recovery phrase display
- All buttons and warnings
- Added translations for Nip95ConfigManager component:
- Endpoint list and management
- Add/edit/remove actions
- Error messages
- Updated both fr.txt and en.txt translation files
- All text now uses t() function for i18n support
**Pages affectées:**
- pages/settings.tsx
- components/KeyManagementManager.tsx
- components/Nip95ConfigManager.tsx
- public/locales/fr.txt
- public/locales/en.txt
- locales/fr.txt
- locales/en.txt
**Motivations:**
- Fix import error when importing nsec private keys
- Support both string and Uint8Array formats from nip19.decode
**Root causes:**
- nip19.decode returns decoded.data as Uint8Array, not string
- Validation in KeyManagementManager only checked for string type
- importPrivateKey in keyManagement.ts only handled string type
**Correctifs:**
- Updated KeyManagementManager validation to accept Uint8Array
- Updated importPrivateKey to convert Uint8Array to hex using bytesToHex
- Improved error messages to show actual validation errors
**Evolutions:**
- None
**Pages affectées:**
- components/KeyManagementManager.tsx
- lib/keyManagement.ts
**Motivations:**
- Provide a dedicated interface for managing Nostr keys
- Allow users to view public keys (npub and hex)
- Enable importing private keys via URL or text format
- Respect the existing two-level encryption system
**Root causes:**
- No dedicated interface for key management
- Users need to view their public keys easily
- Users need to import keys in various formats (nsec URL, nsec text, hex)
**Correctifs:**
- None (new feature)
**Evolutions:**
- Created KeyManagementManager component for key management
- Added public key display (npub and hex formats)
- Implemented private key import with support for:
- nostr:// URLs with nsec
- nsec text format (nsec1...)
- hex format (64 characters)
- Automatic key extraction from URLs
- Account replacement warning and confirmation
- Recovery phrase display after import
- Individual copy buttons for each key format
- Integration in settings page
**Pages affectées:**
- components/KeyManagementManager.tsx (new)
- pages/settings.tsx (modified)
- features/key-management-configuration.md (new)
**Motivations:**
- Corriger l'erreur 404 pour favicon.ico demandé par les navigateurs
- Corriger l'erreur 500 de l'API NIP-95 upload empêchant les uploads de fichiers
**Root causes:**
- Fichier favicon.ico manquant dans public/ causant des erreurs 404 répétées
- Incompatibilité entre form-data (npm) et fetch() natif de Node.js dans l'API NIP-95
**Correctifs:**
- Ajout de favicon.svg et mise à jour des références dans les pages
- Remplacement de fetch() par https/http natifs de Node.js dans nip95-upload.ts
- Amélioration de la gestion des erreurs et nettoyage des fichiers temporaires
**Evolutions:**
- Documentation des problèmes et solutions dans fixKnowledge/
**Pages affectées:**
- components/HomeView.tsx
- pages/docs.tsx
- pages/presentation.tsx
- pages/api/nip95-upload.ts
- features/account-creation-buttons-separation.md
- fixKnowledge/favicon-404-error.md (nouveau)
- fixKnowledge/nip95-upload-500-error.md (nouveau)
- public/favicon.svg (nouveau)
