Nicolas Cantu
58cc2493e5
Initial state: - ia_dev was historically referenced as ./ia_dev in docs and integrations, while the vendored module lives under services/ia_dev. - AnythingLLM sync and hook installation had error masking / weak exit signaling. - Proxy layers did not validate proxy path segments, allowing path normalization tricks. Motivation: - Make the IDE-oriented workflow usable (sync -> act -> deploy/preview) with explicit errors. - Reduce security footguns in proxying and script automation. Resolution: - Standardize IA_DEV_ROOT usage and documentation to services/ia_dev. - Add SSH remote data mirroring + optional AnythingLLM ingestion. - Extend AnythingLLM pull sync to support upload-all/prefix and fail on upload errors. - Harden smart-ide-sso-gateway and smart-ide-global-api proxying with safe-path checks and non-leaking error responses. - Improve ia-dev-gateway runner validation and reduce sensitive path leakage. - Add site scaffold tool (Vite/React) with OIDC + chat via sso-gateway -> orchestrator. Root cause: - Historical layout changes (submodule -> vendored tree) and missing central contracts for path resolution. - Missing validation for proxy path traversal patterns. - Overuse of silent fallbacks (|| true, exit 0 on partial failures) in automation scripts. Impacted features: - Project sync: git pull + AnythingLLM sync + remote data mirror ingestion. - Site frontends: SSO gateway proxy and orchestrator intents (rag.query, chat.local). - Agent execution: ia-dev-gateway script runner and SSE output. Code modified: - scripts/remote-data-ssh-sync.sh - scripts/anythingllm-pull-sync/sync.mjs - scripts/install-anythingllm-post-merge-hook.sh - cron/git-pull-project-clones.sh - services/smart-ide-sso-gateway/src/server.ts - services/smart-ide-global-api/src/server.ts - services/smart-ide-orchestrator/src/server.ts - services/ia-dev-gateway/src/server.ts - services/ia_dev/tools/site-generate.sh Documentation modified: - docs/** (architecture, API docs, ia_dev module + integration, scripts) Configurations modified: - config/services.local.env.example - services/*/.env.example Files in deploy modified: - services/ia_dev/deploy/* Files in logs impacted: - logs/ia_dev.log (runtime only) - .logs/* (runtime only) Databases and other sources modified: - None Off-project modifications: - None Files in .smartIde modified: - .smartIde/agents/*.md - services/ia_dev/.smartIde/** Files in .secrets modified: - None New patch version in VERSION: - 0.0.5 CHANGELOG.md updated: - yes
55 lines
2.8 KiB
Plaintext
55 lines
2.8 KiB
Plaintext
fix-lint backend 76 errors (target 75 reached); N0 161 → N_final 85
|
|
|
|
**Initial state:**
|
|
- Backend ESLint had 161 errors (N0). Target: reduce by at least 75 (N_final ≤ 86).
|
|
- Violations: max-params, max-lines, max-lines-per-function, complexity.
|
|
|
|
**Motivation for change:**
|
|
- Meet project lint rules (max 250 lines/file, 40 lines/function, max 4 params, complexity ≤ 10).
|
|
- Reduce backend error count by ≥75 in one batch.
|
|
|
|
**Resolution:**
|
|
- 76 errors fixed. N_final = 85. Target ≥75 reached.
|
|
- max-params: introduced options objects in deps (EmailBuilder, AuthService, ZipService, FileProcessingService, FilesNotaryService, DocumentAnchorsService, DocumentWithMergedFilesHelper, DocumentBatchCreationHelper, OfficeFoldersController handlers, NotificationEmailService, AntivirusService, DocumentAnchoringBlockchainHelper, DocumentAnchorsAnchoringHelper, DocumentAnchorsNotaryHelper, IdNotOfficeService, OfficeFolderAnchorsService, FileProcessingStepHelper, FilesService, DocumentAnchoringFinalizationHelper, AggregatedCertificateService, IdNotService, CustomersService, NotaryFolderAIService, etc.).
|
|
- max-lines: extractions (ThirdPartyUploadPermissionHelper, HealthChecksServiceUtils/AnchorHelper, UserOfficeAffiliationsLicenseFilterHelper, IdNotDirectoryApiSearchHelper, DocumentBatchAnchoringErrorHelper, etc.).
|
|
- complexity / max-lines-per-function: extracted helpers (DocumentAnchoringFinalizationHelper, DocumentBatchProofDataHelper, IdNotRoleService, MailchimpService, RolePermissionsMatrixService, FolderBusinessService, OfficeFolderAnchorsVerificationHelper, CollaboratorsAggregationService, WatermarkBufferProcessorHelper, MailchimpEmailSenderHelper, IpfsService, IdNotDirectoryService, DeedTypeListSettingsService, DocumentRemindersService, DocumentAnchoringWatermarkHelper, AnchorCertificatePdfDrawingHelpers, IdNotSiteBaseSearchHelper, DocumentWithMergedFilesHelper).
|
|
|
|
**Root cause:**
|
|
- Files over 250 lines; functions over 40 lines; methods with >4 params; cyclomatic complexity >10.
|
|
|
|
**Features impacted:**
|
|
- None; refactor only. No API or behaviour change.
|
|
|
|
**Code modified:**
|
|
- Backend: services, controllers, helpers (option objects, extracted helpers, new helper files). Frontend: shared.tsx (folders) alignment.
|
|
|
|
**Documentation modified:**
|
|
- CHANGELOG.md (2.0.63). docs/fixKnowledge/fix-lint-75-errors-batch-2026-03.md (content migrated to wiki via docupdate).
|
|
|
|
**Configurations modified:**
|
|
- None.
|
|
|
|
**Deploy files modified:**
|
|
- deploy/scripts_v2/deploy.sh (if any change present).
|
|
|
|
**Log files impacted:**
|
|
- None.
|
|
|
|
**Databases and other sources modified:**
|
|
- None.
|
|
|
|
**Changes outside project:**
|
|
- None.
|
|
|
|
**Files in .smartIde/ modified:**
|
|
- .smartIde/agents/change-to-all-branches.md, .smartIde/agents/fix-lint.md.
|
|
|
|
**Files in .secrets/ modified:**
|
|
- None.
|
|
|
|
**New patch version in VERSION:**
|
|
- 2.0.63.
|
|
|
|
**CHANGELOG.md updated:**
|
|
- Yes.
|