From e7df62f9cd215d5f531ae2ae7e0778c1d8f331e5 Mon Sep 17 00:00:00 2001
From: NicolasCantu <nicolas.cantu@pm.me>
Date: Tue, 3 Jun 2025 18:12:13 +0200
Subject: [PATCH] Update pcd tests

---
 src/pcd.rs | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/pcd.rs b/src/pcd.rs
index 0923389..0322ed9 100644
--- a/src/pcd.rs
+++ b/src/pcd.rs
@@ -198,13 +198,12 @@ impl PcdCommitments {
         }
 
         if roles.len() > 0 {
-            // This should be very rare, but just in case
             let serialized_roles = roles.to_bytes()?;
 
             let roles_hash = AnkPcdHash::from_value_with_outpoint(&serialized_roles, &serialized_outpoint);
 
             field2hash.insert("roles".to_owned(), roles_hash.to_byte_array());
-        }
+        } // We should probably return an error if roles are empty
 
         Ok(Self(field2hash))
     }
@@ -593,9 +592,9 @@ mod tests {
         let validation_rule = ValidationRule::new(0.5, fields.clone(), 0.5).unwrap();
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
-        let roles = BTreeMap::new();
+        let roles = BTreeMap::new(); // roles are not necessary here, we can leave it empty
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
         let commitments = PcdCommitments::new(&OutPoint::null(), &Pcd::new(attributes), &Roles::new(roles)).unwrap();
         let new_state_merkle_root = commitments.create_merkle_tree().unwrap().root().unwrap();
@@ -654,7 +653,7 @@ mod tests {
         let validation_rule = ValidationRule::new(0.5, fields.clone(), 0.5).unwrap();
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -702,7 +701,7 @@ mod tests {
         let validation_rule = ValidationRule::new(1.0, fields.clone(), 0.5).unwrap();
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -744,7 +743,7 @@ mod tests {
         let validation_rule = ValidationRule::new(0.5, fields.clone(), 0.5).unwrap();
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -789,7 +788,7 @@ mod tests {
         )
         .unwrap()]);
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -837,7 +836,7 @@ mod tests {
         let new_state = json!({ "field1": "new_value1", "field2": "new_value2" });
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -889,7 +888,7 @@ mod tests {
         let new_state = json!({ "field1": "new_value1", "field2": "new_value2" });
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -942,7 +941,7 @@ mod tests {
         let new_state = json!({ "field1": "old_value1", "field2": "new_value2" });
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));
@@ -995,7 +994,7 @@ mod tests {
         let new_state = json!({ "field1": "old_value1", "field2": "new_value2" });
 
         let clear_state_value = json!({"field1": "value1", "field2": "value2"});
-        let pcd: BTreeMap<String, Value> = serde_json::from_value(clear_state_value).unwrap();
+        let pcd: Pcd = clear_state_value.try_into().unwrap();
         let public_data = BTreeMap::new();
         let roles = BTreeMap::new();
         let attributes = BTreeMap::from_iter(pcd.into_iter().chain(public_data));