From 12da1740e24227f3053e79eb2470241ec92c27c8 Mon Sep 17 00:00:00 2001 From: Sosthene Date: Tue, 29 Oct 2024 13:02:27 +0100 Subject: [PATCH] Optimise to_network_msg: no need to clone to_sign --- src/prd.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/prd.rs b/src/prd.rs index 71b7d61..87c631d 100644 --- a/src/prd.rs +++ b/src/prd.rs @@ -238,17 +238,16 @@ impl Prd { /// Generate the signed proof and serialize to send over the network pub fn to_network_msg(&self, sp_wallet: &SpWallet) -> Result { let spend_sk: SecretKey = sp_wallet.get_client().get_spend_key().try_into()?; - let to_sign = self.clone(); // we sign the whole prd, incl the keys, for each recipient + let mut to_sign = self.clone(); // we sign the whole prd, incl the keys, for each recipient let message_hash = AnkHash::Message(AnkMessageHash::from_message(to_sign.to_string().as_bytes())); let proof = Proof::new(message_hash, spend_sk); - let mut res = self.clone(); - res.proof = Some(proof); + to_sign.proof = Some(proof); - Ok(res.to_string()) + Ok(to_sign.to_string()) } pub fn to_string(&self) -> String {