Refacto/notifications (#101)

src/app/api/notary/UserNotificationController.ts

@@ -5,6 +5,7 @@ import { Service } from "typedi";
 import UserNotification from "le-coffre-resources/dist/Notary/UserNotification";
 import UserNotificationService from "@Services/common/UserNotificationService/UserNotificationService";
 import authHandler from "@App/middlewares/AuthHandler";
+import { Prisma } from "@prisma/client";
 
 @Controller()
 @Service()
@@ -16,7 +17,7 @@ export default class UserNotificationController extends ApiController {
 	/**
 	 * @description Get all customers
 	 */
-	@Get("/api/v1/notifications", [authHandler])
+	@Get("/api/v1/notary/notifications", [authHandler])
 	protected async get(req: Request, response: Response) {
 		try {
 			//get query
@@ -25,11 +26,13 @@ export default class UserNotificationController extends ApiController {
 				query = JSON.parse(req.query["q"] as string);
 			}
 
-			if (query.where) {
+
-				query.where = { ...query.where, user: { uid: req.body.user.uid } };
+			const userId: string = req.body.user.userId;
-			} else {
+			if(query.where?.user_uid) delete query.where.user_uid;
-				query.where = { user: { uid: req.body.user.uid } };
+			if(query.where?.user?.uid) delete query.where.user.uid;
-			}
+			const notificationWhereInput: Prisma.UserNotificationsWhereInput = { ...query.where, user_uid: userId };
+			query.where = notificationWhereInput;
+			
 			query.include = { notification: true };
 			//call service to get prisma entity
 			const userNotificationEntities = await this.userNotificationService.get(query);
@@ -48,7 +51,7 @@ export default class UserNotificationController extends ApiController {
 	/**
 	 * @description Modify a specific customer by uid
 	 */
-	@Put("/api/v1/notifications/:uid")
+	@Put("/api/v1/notary/notifications/:uid", [authHandler])
 	protected async put(req: Request, response: Response) {
 		try {
 			const uid = req.params["uid"];
@@ -64,6 +67,11 @@ export default class UserNotificationController extends ApiController {
 				return;
 			}
 
+			if(userNotificationFound.user_uid !== req.body.user.userId) {
+				this.httpForbidden(response, "You are not allowed to update this user notification");
+				return;
+			}
+
 			//init IUser resource with request body values
 			const userNotificationEntity = UserNotification.hydrate<UserNotification>(req.body);
 
@@ -86,7 +94,7 @@ export default class UserNotificationController extends ApiController {
 	/**
 	 * @description Get a specific customer by uid
 	 */
-	@Get("/api/v1/notifications/:uid")
+	@Get("/api/v1/notary/notifications/:uid", [authHandler])
 	protected async getOneByUid(req: Request, response: Response) {
 		try {
 			const uid = req.params["uid"];
@@ -108,6 +116,11 @@ export default class UserNotificationController extends ApiController {
 				return;
 			}
 
+			if(userNotificationEntity.user_uid !== req.body.userId) {
+				this.httpForbidden(response, "You are allowed to get this user notification");
+				return;
+			}
+
 			//Hydrate ressource with prisma entity
 			const userNotification = UserNotification.hydrate<UserNotification>(userNotificationEntity, { strategy: "excludeAll" });
 

src/app/index.ts

@@ -47,8 +47,7 @@ import VotesController from "./api/super-admin/VotesController";
 import LiveVoteController from "./api/super-admin/LiveVoteController";
 import DocumentControllerId360 from "./api/id360/DocumentController";
 import CustomerControllerId360 from "./api/id360/CustomerController";
-
+import UserNotificationController from "./api/notary/UserNotificationController";
-import UserNotificationController from "./api/common/UserNotificationController";
 
 
 /**

src/common/system/controller-pattern/BaseController.ts

@@ -40,6 +40,10 @@ export default abstract class BaseController {
 		return this.httpResponse(response, HttpCodes.NOT_IMPLEMENTED, responseData);
 	}
 
+	protected httpForbidden(response: Response, responseData: IResponseData = "Forbidden") {
+		return this.httpResponse(response, HttpCodes.FORBIDDEN, responseData);
+	}
+
 	protected httpResponse(response: Response, httpCode: HttpCodes, responseData: IResponseData = {}) {
 		if (responseData instanceof Error) {
 			throw responseData;

src/common/system/controller-pattern/HttpCodes.ts

@@ -8,5 +8,6 @@ enum HttpCodes {
 	NOT_IMPLEMENTED = 501,
 	NOT_FOUND = 404,
 	UNAUTHORIZED = 401,
+	FORBIDDEN = 403,
 }
 export default HttpCodes;