diff --git a/src/common/config/variables/Variables.ts b/src/common/config/variables/Variables.ts index 5a46fd26..1a618ab6 100644 --- a/src/common/config/variables/Variables.ts +++ b/src/common/config/variables/Variables.ts @@ -121,6 +121,9 @@ export class BackendVariables { @IsNotEmpty() public readonly OVH_CONSUMER_KEY!: string; + @IsNotEmpty() + public readonly OVH_SMS_SERVICE_NAME!: string; + @IsNotEmpty() public readonly SMS_FACTOR_TOKEN!: string; @@ -165,6 +168,7 @@ export class BackendVariables { this.OVH_APP_KEY = process.env["OVH_APP_KEY"]!; this.OVH_APP_SECRET = process.env["OVH_APP_SECRET"]!; this.OVH_CONSUMER_KEY = process.env["OVH_CONSUMER_KEY"]!; + this.OVH_SMS_SERVICE_NAME = process.env["OVH_SMS_SERVICE_NAME"]!; this.SMS_FACTOR_TOKEN = process.env["SMS_FACTOR_TOKEN"]!; diff --git a/src/services/common/OvhService/OvhService.ts b/src/services/common/OvhService/OvhService.ts index f70b59d2..94fb0e05 100644 --- a/src/services/common/OvhService/OvhService.ts +++ b/src/services/common/OvhService/OvhService.ts @@ -14,30 +14,22 @@ export default class OvhService extends BaseService { appSecret: this.variables.OVH_APP_SECRET, consumerKey: this.variables.OVH_CONSUMER_KEY, }); - - ovh.request("GET", "/sms", function (err: any, serviceName: string) { - if (err) { - console.log(err, serviceName); - return false; + + const serviceName = this.variables.OVH_SMS_SERVICE_NAME; + + ovh.request('POST', '/sms/' + serviceName + '/jobs/', { + message: message, + sender: "LeCoffre", + receivers: [phoneNumber], + }, (error: any, response: any) => { + if (error) { + console.error('Error sending Ovh Sms:', error); + return false; } else { - console.log("My account SMS is " + serviceName); - - // Send a simple SMS with a short number using your serviceName - ovh.request( - "POST", - "/sms/" + serviceName + "/jobs", - { - message: message, - senderForResponse: true, - receivers: [phoneNumber], - }, - function (errsend: any, result: any) { - console.log(errsend, result); - }, - ); - return true; + console.log('SMS sent successfully via Ovh:', response); + return true; } }); - return false; + return false; } } diff --git a/src/services/common/SmsFactorService/SmsFactorService.ts b/src/services/common/SmsFactorService/SmsFactorService.ts index 851152ed..32bd38ea 100644 --- a/src/services/common/SmsFactorService/SmsFactorService.ts +++ b/src/services/common/SmsFactorService/SmsFactorService.ts @@ -17,12 +17,12 @@ export default class SmsFactorService extends BaseService { to: phoneNumber, text: message, }).then(response => { - console.log('SMS sent successfully:', response.data); + console.log('SMS sent successfully via Sms Factor :', response.data); return true; }) .catch(error => { - console.error('Error sending SMS:', error.response.data); + console.error('Error sending Sms Factor SMS:', error.response.data); return false; }); return false; diff --git a/src/services/customer/CustomersService/CustomersService.ts b/src/services/customer/CustomersService/CustomersService.ts index 67dc09a5..46a0843b 100644 --- a/src/services/customer/CustomersService/CustomersService.ts +++ b/src/services/customer/CustomersService/CustomersService.ts @@ -360,7 +360,7 @@ export default class CustomersService extends BaseService { // Envoi du SMS if (!customer.contact?.phone_number) return; - let success = await selectedProvider.sendSms(customer.contact?.phone_number, totpPin.toString()); + let success = await selectedProvider.sendSms(customer.contact?.phone_number, totpPin.toString()); // Si l'envoi échoue, basculez automatiquement sur le second fournisseur if (!success) {