From 81fc7644a0bcd389d350d4547542c6e530005a5c Mon Sep 17 00:00:00 2001
From: Maxime Lalo <maxime.lalo.pro@gmail.com>
Date: Fri, 29 Sep 2023 16:53:35 +0200
Subject: [PATCH] :bug: Code optimization

---
 src/app/api/admin/OfficeRolesController.ts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/app/api/admin/OfficeRolesController.ts b/src/app/api/admin/OfficeRolesController.ts
index dbde1263..bd989779 100644
--- a/src/app/api/admin/OfficeRolesController.ts
+++ b/src/app/api/admin/OfficeRolesController.ts
@@ -110,18 +110,16 @@ export default class OfficeRolesController extends ApiController {
 			}
 
 			if (req.body.rules) {
-				const rules = req.body.rules;
 				const allRules = await this.rulesService.get({
 					where: {
 						namespace: "notary",
 					},
 				});
 
-				const rulesToEdit = rules.filter((rule: any) => {
+				req.body.rules = req.body.rules.filter((rule: any) => {
 					const ruleFound = allRules.find((r) => r.uid === rule.uid && r.namespace === "notary");
 					return ruleFound;
 				});
-				req.body.rules = rulesToEdit;
 			}
 			//init IOfficeRole resource with request body values
 			const officeRoleEntity = OfficeRole.hydrate<OfficeRole>(req.body);