4nk/lecoffre-back
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't trigger updateUser on missing email/phone
All checks were successful
Demo - Build & Deploy to Scaleway / build-and-push-images-lecoffre (push) Successful in 1m43s
Details
Demo - Build & Deploy to Scaleway / deploy-back-lecoffre (push) Successful in 4s
Details
Demo - Build & Deploy to Scaleway / deploy-cron-lecoffre (push) Successful in 3s
Details

Browse Source
This commit is contained in:
Sosthene 2025-07-24 00:03:49 +02:00
parent 59ffd0a974
commit 103cfbd23c
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/services/common/IdNotService/IdNotService.ts
View File

@ -316,16 +316,12 @@ export default class IdNotService extends BaseService {
}
}
let updates = 0;
console.log("user.office_membership.idNot", JSON.stringify(user.office_membership!.idNot));
console.log("userData.entite.ou", JSON.stringify(userData.entite.ou));
let update = false;
if (user.office_membership!.idNot !== userData.entite.ou) {
console.log("Updating user.office_membership");
updates++;
update = true;
let officeData = (await this.officeService.get({ where: { idNot: userData.entite.ou } }))[0];
console.log("officeData", JSON.stringify(officeData));
if (!officeData) {
let officeLocationData: IOfficeLocation;
@ -361,17 +357,17 @@ export default class IdNotService extends BaseService {
console.log("Updated user.office_membership", JSON.stringify(user.office_membership));
}
if (user.contact!.email !== userData.mailRattachement) {
updates++;
if (userData.mailRattachement && (user.contact!.email === null || user.contact!.email === undefined || user.contact!.email !== userData.mailRattachement)) {
update = true;
user.contact!.email = userData.mailRattachement;
console.log("Updated user.contact.email", JSON.stringify(user.contact!.email));
}
if (user.contact!.cell_phone_number !== userData.numeroMobile) {
updates++;
if (userData.numeroMobile && (user.contact!.cell_phone_number === null || user.contact!.cell_phone_number === undefined || user.contact!.cell_phone_number !== userData.numeroMobile)) {
update = true;
user.contact!.cell_phone_number = userData.numeroMobile;
console.log("Updated user.contact.cell_phone_number", JSON.stringify(user.contact!.cell_phone_number));
}
if (updates != 0) {
if (update) {
// Filter out null values before updating to prevent Prisma errors
const convertedUser = this.convertNullToUndefined(user);
await this.userService.update(user.uid!, convertedUser);