From 18936f18e77000ee334479873fecae53b3a86668 Mon Sep 17 00:00:00 2001 From: Sadrinho27 Date: Fri, 12 Sep 2025 11:55:54 +0200 Subject: [PATCH] Remove hardcoded values & updated env file --- .env.exemple | 17 ++++++----------- quick-test-rattachements.js | 2 +- src/config/index.ts | 6 +++--- src/config/stripe.ts | 2 +- test-rattachements-endpoint.js | 2 +- test-signer-reconnection.js | 2 +- 6 files changed, 13 insertions(+), 18 deletions(-) diff --git a/.env.exemple b/.env.exemple index e0bba5c..8747399 100644 --- a/.env.exemple +++ b/.env.exemple @@ -1,3 +1,7 @@ +# Configuration IDNOT +IDNOT_ANNUARY_BASE_URL= +IDNOT_API_KEY= + # Configuration OVH OVH_APP_KEY= OVH_APP_SECRET= @@ -26,14 +30,5 @@ DECLINED= 4000 0025 0000 3155 #Paiement refusé # Configuration serveur APP_HOST= -PORT= - -# Configuration PostgreSQL -DB_HOST= -DB_PORT= -DB_NAME= -DB_USER= -DB_PASSWORD= - -# Configuration idnot -IDNOT_API_KEY= +API_BASE_URL= +DEFAULT_STORAGE= diff --git a/quick-test-rattachements.js b/quick-test-rattachements.js index 7243011..f203b15 100755 --- a/quick-test-rattachements.js +++ b/quick-test-rattachements.js @@ -4,7 +4,7 @@ const fetch = require('node-fetch'); const { SDKSignerClient } = require('sdk-signer-client'); // Quick test configuration -const BASE_URL = 'http://localhost:8080'; +const BASE_URL = process.env.API_BASE_URL; const ENDPOINT = '/api/v1/idnot/user/rattachements'; // Base endpoint, idnot will be added as path parameter const signerConfig = { diff --git a/src/config/index.ts b/src/config/index.ts index 214b871..96aae65 100644 --- a/src/config/index.ts +++ b/src/config/index.ts @@ -4,11 +4,11 @@ dotenv.config(); export const config = { port: process.env.PORT || 8080, - defaultStorage: process.env.DEFAULT_STORAGE || 'https://dev3.4nkweb.com/storage', - appHost: process.env.APP_HOST || 'http://localhost:3000', + defaultStorage: process.env.DEFAULT_STORAGE, + appHost: process.env.APP_HOST, cors: { - origin: 'http://localhost:3000', + origin: process.env.APP_HOST, methods: ['GET', 'POST', 'PUT', 'DELETE', 'OPTIONS'], allowedHeaders: ['Content-Type', 'x-session-id', 'Authorization'], credentials: true diff --git a/src/config/stripe.ts b/src/config/stripe.ts index 267b1da..49d489e 100644 --- a/src/config/stripe.ts +++ b/src/config/stripe.ts @@ -1,5 +1,5 @@ export const stripeConfig = { STRIPE_SECRET_KEY: process.env.STRIPE_SECRET_KEY, STRIPE_WEBHOOK_SECRET: process.env.STRIPE_WEBHOOK_SECRET, - APP_HOST: process.env.APP_HOST || 'http://localhost:3000', + APP_HOST: process.env.APP_HOST, }; diff --git a/test-rattachements-endpoint.js b/test-rattachements-endpoint.js index 319edb4..fa5eece 100755 --- a/test-rattachements-endpoint.js +++ b/test-rattachements-endpoint.js @@ -3,7 +3,7 @@ const fetch = require('node-fetch'); // Test configuration -const BASE_URL = 'http://localhost:8080'; +const BASE_URL = process.env.API_BASE_URL; const ENDPOINT = '/api/v1/idnot/user'; // Base endpoint, idnot will be added as path parameter // Test cases for the rattachements endpoint diff --git a/test-signer-reconnection.js b/test-signer-reconnection.js index 5ddb648..ba2ea34 100755 --- a/test-signer-reconnection.js +++ b/test-signer-reconnection.js @@ -15,7 +15,7 @@ const fetch = require('node-fetch'); -const API_BASE = process.env.API_BASE || 'http://localhost:8080'; +const API_BASE = process.env.API_BASE_URL; const TEST_DURATION = 60000; // 1 minute test const CHECK_INTERVAL = 2000; // Check every 2 seconds