From c82c219a2834b918e0d7ceaa646a97ff0f355648 Mon Sep 17 00:00:00 2001
From: NicolasCantu <nicolas.cantu@pm.me>
Date: Wed, 12 Mar 2025 15:44:00 +0100
Subject: [PATCH] Update approveChange

---
 src/pages/chat/chat.ts        |  4 ++--
 src/pages/process/process.ts  |  2 +-
 src/services/modal.service.ts |  4 ++--
 src/services/service.ts       | 18 +++++++++++-------
 4 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/src/pages/chat/chat.ts b/src/pages/chat/chat.ts
index 4c63f95..0a9da25 100755
--- a/src/pages/chat/chat.ts
+++ b/src/pages/chat/chat.ts
@@ -349,7 +349,7 @@ class ChatElement extends HTMLElement {
             await service.handleApiReturn(createPrdReturn);
 
             // Now we validate the new state
-            const approveChangeReturn = service.approveChange(this.selectedChatProcessId, newStateId);
+            const approveChangeReturn = await service.approveChange(this.selectedChatProcessId, newStateId);
             await service.handleApiReturn(approveChangeReturn);
 
             await this.lookForMyDms();
@@ -672,7 +672,7 @@ class ChatElement extends HTMLElement {
                         this.selectedChatProcessId = processId;
                         const createPrdReturn = await service.createPrdUpdate(processId, stateId);
                         await service.handleApiReturn(createPrdReturn);
-                        const approveChangeReturn = service.approveChange(processId, stateId);
+                        const approveChangeReturn = await service.approveChange(processId, stateId);
                         await service.handleApiReturn(approveChangeReturn);
                     }, 500);
                 } catch (e) {
diff --git a/src/pages/process/process.ts b/src/pages/process/process.ts
index 2c26999..fadea30 100755
--- a/src/pages/process/process.ts
+++ b/src/pages/process/process.ts
@@ -479,7 +479,7 @@ async function createMessagingProcess(): Promise<void> {
     await service.handleApiReturn(createProcessReturn);
     const createPrdReturn = await service.createPrdUpdate(processId, stateId);
     await service.handleApiReturn(createPrdReturn);
-    const approveChangeReturn = service.approveChange(processId, stateId);
+    const approveChangeReturn = await service.approveChange(processId, stateId);
     await service.handleApiReturn(approveChangeReturn);
   }, 500)
 }
diff --git a/src/services/modal.service.ts b/src/services/modal.service.ts
index e331549..4d42ad3 100755
--- a/src/services/modal.service.ts
+++ b/src/services/modal.service.ts
@@ -185,7 +185,7 @@ export default class ModalService {
 
       // We send confirmation that we validate the change
       try {
-        const approveChangeReturn = service.approveChange(this.processId!, this.stateId!);
+        const approveChangeReturn = await service.approveChange(this.processId!, this.stateId!);
         await service.handleApiReturn(approveChangeReturn);
 
         await this.injectWaitingModal();
@@ -234,7 +234,7 @@ export default class ModalService {
 
       // We send confirmation that we validate the change
       try {
-        const approveChangeReturn = service.approveChange(this.processId!, this.stateId!);
+        const approveChangeReturn = await service.approveChange(this.processId!, this.stateId!);
         await service.handleApiReturn(approveChangeReturn);
       } catch (e) {
         throw e;
diff --git a/src/services/service.ts b/src/services/service.ts
index 0972b3c..025bb72 100755
--- a/src/services/service.ts
+++ b/src/services/service.ts
@@ -389,21 +389,25 @@ export default class Services {
     }
   }
 
-  public approveChange(processId: string, stateId: string): ApiReturn {
+  public async approveChange(processId: string, stateId: string): Promise<ApiReturn> {
+    const process = await this.getProcess(processId);
+    if (!process) {
+      throw new Error('Failed to get process from db');
+    }
     try {
-      return this.sdkClient.validate_state(processId, stateId);
+      return this.sdkClient.validate_state(process, stateId);
     } catch (e) {
       throw new Error(`Failed to create prd response: ${e}`);
     }
   }
 
-  public rejectChange(): ApiReturn {
-    if (!this.currentProcess || !this.currentUpdateMerkleRoot) {
-      throw new Error('No current process and/or current update defined');
+  public async rejectChange(processId: string, stateId: string): Promise<ApiReturn> {
+    const process = await this.getProcess(processId);
+    if (!process) {
+      throw new Error('Failed to get process from db');
     }
-
     try {
-      return this.sdkClient.refuse_state(this.currentProcess, this.currentUpdateMerkleRoot);
+      return this.sdkClient.refuse_state(process, stateId);
     } catch (e) {
       throw new Error(`Failed to create prd response: ${e}`);
     }